Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign F1 as the hotkey to display node help docs #12894

Merged
merged 3 commits into from
May 18, 2022
Merged

Assign F1 as the hotkey to display node help docs #12894

merged 3 commits into from
May 18, 2022

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 17, 2022 •
edited
Loading

Purpose

  • Assign F1 as the hotkey to display node help docs DYN-4900
  • Update primer links DYN-4875

DynamoSandbox_HUHRJpoNcb

Screen Shot 2022-05-18 at 4 51 58 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Assign F1 as the hotkey to display node help docs

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit marked this pull request as ready for review May 18, 2022 17:59
@zeusongit zeusongit changed the title [WIP] Assign F1 as the hotkey to display node help docs Assign F1 as the hotkey to display node help docs May 18, 2022
QilongTang
QilongTang reviewed May 18, 2022
View reviewed changes
src/DynamoCoreWpf/Views/Core/NodeView.xaml
@@ -130,6 +130,14 @@
</Style>
</Label.Style>
</Label>
<TextBlock x:Name="InputGestureText"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah so this is the trick?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the missing piece

@zeusongit zeusongit merged commit c8a7dbd into DynamoDS:master May 18, 2022
@avidit avidit mentioned this pull request May 19, 2022
Closed
@zeusongit zeusongit added this to the 2.15.0 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang left review comments

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zeusongit @QilongTang @reddyashish