-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package links to Package details view #12877
Conversation
@QilongTang @Jingyi-Wen |
Yeah this is intended. LGTM! |
@Jingyi-Wen I believe we intend to have hyper links? No? |
Oh my apologies I missed it, yes they should be hyper links |
LGTM, can you also record a gif for demo purposes and maybe look for unit test possibilities for the two new properties you add? If we dont unit test them right now, I am fine skipping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
https://jira.autodesk.com/browse/DYN-4893
Display site URL and repository URL on package details view if available.
GIF:
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@DynamoDS/dynamo