Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package links to Package details view #12877

Merged
merged 6 commits into from
May 13, 2022
Merged

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 11, 2022

Purpose

https://jira.autodesk.com/browse/DYN-4893
Display site URL and repository URL on package details view if available.

Screen Shot 2022-05-12 at 2 26 09 PM

GIF:
DynamoSandbox_LSQnpg9QMR

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Add package links to Package details view

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit requested a review from QilongTang May 11, 2022 22:45
@zeusongit
Copy link
Contributor Author

@QilongTang @Jingyi-Wen
I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.

@Jingyi-Wen
Copy link

@QilongTang @Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.

Yeah this is intended. LGTM!

@QilongTang
Copy link
Contributor

@QilongTang @Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.

Yeah this is intended. LGTM!

@Jingyi-Wen I believe we intend to have hyper links? No?

@Jingyi-Wen
Copy link

@QilongTang @Jingyi-Wen I displayed the whole link, it was unclear from the mockup, if we want the actual link or some clickable hyperlink like Site URL that opens the URL. Let me know if that is what was required, I will update the PR. Thanks.

Yeah this is intended. LGTM!

@Jingyi-Wen I believe we intend to have hyper links? No?

Oh my apologies I missed it, yes they should be hyper links

@QilongTang
Copy link
Contributor

LGTM, can you also record a gif for demo purposes and maybe look for unit test possibilities for the two new properties you add? If we dont unit test them right now, I am fine skipping

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeusongit zeusongit merged commit a1e1301 into DynamoDS:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants