Package publish crash fix and package files pre-populate bug fix #12859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
May 5, 2022
| @@ -1339,7 +1343,7 @@ private void RemoveItem(object parameter) | |||
| } | |||
|
|
|||
| PackageContents.Remove(PackageContents | |||
| .First(x => x.FileInfo.FullName == packageItemRootViewModel.FileInfo.FullName)); | |||
| .First(x => x.FileInfo?.FullName == packageItemRootViewModel.FileInfo.FullName)); | |||
There was a problem hiding this comment.
Just want to confirm, if the info is null, the remove will do nothing right?
There was a problem hiding this comment.
Yes, it will basically move over and ignore the null, earlier it was throwing object null error, because FileInfo was null for additional files
reddyashish
approved these changes
May 5, 2022
QilongTang
approved these changes
May 6, 2022
|
Although the changes looks good, looks like our SelfServe job machine has some failure. So merging is blocked |
|
Restarted a build on selfserve now that they are passing (almost) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA:
https://jira.autodesk.com/browse/DYN-4918
https://jira.autodesk.com/browse/DYN-4919
This PR fixes 2 problems:
FileInfoobject.GIF:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo
@Amoursol