DYN-4800: Bump Python version to 3.9.12 #12815
Conversation
| @@ -376,6 +376,8 @@ public DSCPythonCodeCompletionProviderCore() | |||
| BasicVariableTypes.Add(Tuple.Create(LIST_VARIABLE, typeof(PyList))); | |||
| BasicVariableTypes.Add(Tuple.Create(DICT_VARIABLE, typeof(PyDict))); | |||
|
|
|||
| Python.Included.Installer.SetupPython().Wait(); | |||
There was a problem hiding this comment.
why is this necessary? The DSCPython engine should do this already, should it not?
I think it's worth testing this change in Revit context if it's really required.
There was a problem hiding this comment.
There is a note in Dynamo
NOTE: Calling SetupPython multiple times will add the install location to the path many times,
/// potentially causing the environment variable to overflow.
I think we might be doing this already ...maybe we should try to only run SetupPython() only once ...(keep a isAlreadySetup flag somewhere)
Please search for all occurrences of SetupPython()
There was a problem hiding this comment.
I actually was able to get in here without having python initialized. And we are already calling this method in multiple places. I will take a look.
There was a problem hiding this comment.
We are now calling SetupPython() every where. That method maintain a just do it once flag.
| @@ -336,7 +336,7 @@ import os | |||
| /// NOTE: Calling SetupPython multiple times will add the install location to the path many times, | |||
| /// potentially causing the environment variable to overflow. | |||
| /// </summary> | |||
| private static void InstallPython() | |||
| internal static void InstallPython() | |||
There was a problem hiding this comment.
I made it internal. Would it be OK to make this public?
There was a problem hiding this comment.
since it has a side effect that is potentially dangerous I'd prefer if extensions could not call it.
|
@mjkkirschner PTAL! |
Purpose
This pull request does:
2.5.23.9.12Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of