Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix 2.3.2 Cherry-Pick #12804 #12808

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Hotfix 2.3.2 Cherry-Pick #12804 #12808

merged 4 commits into from
Apr 19, 2022

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 18, 2022 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Hotfix 2.3.2 - update Greg and RestSharp (Cherry-picking #12804)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Hotfix 2.3.2 - update Greg and RestSharp

Reviewers

@DynamoDS/dynamo

FYIs

QilongTang and others added 2 commits April 18, 2022 09:00
@QilongTang
2.6.2 Hotfix - Update RestSharp and Greg (#12804)
6f8e0f4 
* Update RestSharp and Greg

* Update

* versions

* version updates for net452

* Update Greg version

* Update Greg version
@QilongTang
Update version
afa38c4
@QilongTang QilongTang added this to the 2.3.2 milestone Apr 18, 2022
@QilongTang
Copy link
Contributor Author

Build of it passed
image

reddyashish
reddyashish reviewed Apr 18, 2022
View reviewed changes
src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs Outdated
@@ -45,7 +45,7 @@
// to distinguish one build from another. AssemblyFileVersion is specified
// in AssemblyVersionInfo.cs so that it can be easily incremented by the
// automated build process.
[assembly: AssemblyVersion("2.3.1.11724")]
[assembly: AssemblyVersion("2.3.2.15684")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually meant to be submitted since the file was not updated locally correctly for me before. But I can revert for now and inspect build machine later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the EngOps build failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is expected @reddyashish , see reason in original PR. The older build is depending on older version of .Net which is not on current build machine

@QilongTang QilongTang merged commit ecdd570 into RC2.3.2_master Apr 19, 2022
@QilongTang QilongTang deleted the UpdateGreg branch April 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@QilongTang @reddyashish