Allow pkgs to partially load if some of the assemblies are good

src/DynamoCore/Models/DynamoModel.cs

@@ -1420,17 +1420,26 @@ internal void LoadNodeLibrary(Assembly assem, bool suppressZeroTouchLibraryLoad
            // I think this is consistent with the current behavior - IE today - if a nodeModel exists in an assembly, the rest of the assembly 
            // is not imported as ZT - the same will be true if the assembly contains a NodeViewCustomization.
 
-           // TODO(mjk) draw up matrix of current behaviors which nodeLib flag can control.
-            if (!NodeModelAssemblyLoader.ContainsNodeModelSubType(assem)
-                && !(NodeModelAssemblyLoader.ContainsNodeViewCustomizationType(assem)))
+            bool nodeModelOrNodeView;
+            try
+            {
+                nodeModelOrNodeView = !NodeModelAssemblyLoader.ContainsNodeModelSubType(assem)
+                && !(NodeModelAssemblyLoader.ContainsNodeViewCustomizationType(assem));
+            } 
+            catch (Exception ex) {
+                throw new Exceptions.LibraryLoadFailedException(assem.Location, ex.Message);
+            }
+
+            // TODO(mjk) draw up matrix of current behaviors which nodeLib flag can control.
+            if (nodeModelOrNodeView)
             {
                 if (suppressZeroTouchLibraryLoad)
                 {
                     LibraryServices.LoadNodeLibrary(assem.Location, false);
                 }
                 else
                 {
-                    LibraryServices.ImportLibrary(assem.Location);
+                    LibraryServices.ImportLibrary(assem.Location, false);
                 }
 
                 return;

src/DynamoPackages/PackageLoader.cs

@@ -246,9 +246,11 @@ private void TryLoadPackageIntoLibrary(Package package)
             if (package.LoadState.State == PackageLoadState.StateTypes.Unloaded) return;
 
             List<Assembly> loadedNodeLibs = new List<Assembly>();
+            List<Assembly> failedNodeLibs = new List<Assembly>();
             try
             {
-                // load node libraries
+                bool fatalError = false;
+                // Try to load node libraries from all assemblies
                 foreach (var assem in package.EnumerateAndLoadAssembliesInBinDirectory())
                 {
                     if (assem.IsNodeLibrary)
@@ -258,13 +260,29 @@ private void TryLoadPackageIntoLibrary(Package package)
                             OnRequestLoadNodeLibrary(assem.Assembly);
                             loadedNodeLibs.Add(assem.Assembly);
                         }
-                        catch (LibraryLoadFailedException ex)
+                        catch (Exception ex)
                         {
-                            Log(ex.GetType() + ": " + ex.Message);
+                            failedNodeLibs.Add(assem.Assembly);
+                            if (ex is LibraryLoadFailedException)
+                            {
+                                // Managed exception
+                                // We can still try to load other parts of the package
+                                Log(ex.GetType() + ": " + ex.Message);
+                            }
+                            else
+                            {
+                                // Everything else is considered fatal to the package loading operation.
+                                fatalError = true;
+                            }
                         }
                     }
                 }
 
+                if (fatalError)
+                {
+                    throw new Exception("Failed to load the following assemblies : " + string.Join(", ", failedNodeLibs.Select(x => Path.GetFileName(x.Location))));
+                }
+
                 // load custom nodes
                 var packageInfo = new Graph.Workspaces.PackageInfo(package.Name, new Version(package.VersionName));
                 var customNodes = OnRequestLoadCustomNodeDirectory(package.CustomNodeDirectory, packageInfo);
@@ -292,22 +310,25 @@ private void TryLoadPackageIntoLibrary(Package package)
                 PythonServices.PythonEngineManager.Instance.
                     LoadPythonEngine(package.LoadedAssemblies.Select(x => x.Assembly));
             }
-            catch (CustomNodePackageLoadException e)
+            catch (Exception e)
             {
-                Package originalPackage =
-                    localPackages.FirstOrDefault(x => x.CustomNodeDirectory == e.InstalledPath);
-                OnConflictingPackageLoaded(originalPackage, package);
+                // Try to load any valid node libraries even if the package is in error state
+                PackagesLoaded?.Invoke(loadedNodeLibs);
 
                 package.LoadState.SetAsError(e.Message);
-            }
-            catch (Exception e)
-            {
-                if (e is DynamoServices.AssemblyBlockedException)
+
+                if (e is CustomNodePackageLoadException ce)
+                {
+                    Package originalPackage =
+                        localPackages.FirstOrDefault(x => x.CustomNodeDirectory == ce.InstalledPath);
+                    OnConflictingPackageLoaded(originalPackage, package);
+                }
+                else if (e is DynamoServices.AssemblyBlockedException)
                 {
                     var failureMessage = string.Format(Properties.Resources.PackageLoadFailureForBlockedAssembly, e.Message);
                     DynamoServices.LoadLibraryEvents.OnLoadLibraryFailure(failureMessage, Properties.Resources.LibraryLoadFailureMessageBoxTitle);
                 }
-                package.LoadState.SetAsError(e.Message);
+
                 Log("Exception when attempting to load package " + package.Name + " from " + package.RootDirectory);
                 Log(e.GetType() + ": " + e.Message);
             }