Allow pkgs to partially load if some of the assemblies are good

src/DynamoCore/Models/DynamoModel.cs

@@ -1420,17 +1420,26 @@ internal void LoadNodeLibrary(Assembly assem, bool suppressZeroTouchLibraryLoad
            // I think this is consistent with the current behavior - IE today - if a nodeModel exists in an assembly, the rest of the assembly 
            // is not imported as ZT - the same will be true if the assembly contains a NodeViewCustomization.
 
-           // TODO(mjk) draw up matrix of current behaviors which nodeLib flag can control.
-            if (!NodeModelAssemblyLoader.ContainsNodeModelSubType(assem)
-                && !(NodeModelAssemblyLoader.ContainsNodeViewCustomizationType(assem)))
+            bool hasNodeModelOrNodeViewTypes;
+            try
+            {
+                hasNodeModelOrNodeViewTypes = NodeModelAssemblyLoader.ContainsNodeModelSubType(assem)
+                || (NodeModelAssemblyLoader.ContainsNodeViewCustomizationType(assem));
+            } 
+            catch (Exception ex) {
+                throw new Exceptions.LibraryLoadFailedException(assem.Location, ex.Message);
+            }
+
+            // TODO(mjk) draw up matrix of current behaviors which nodeLib flag can control.
+            if (!hasNodeModelOrNodeViewTypes)
             {
                 if (suppressZeroTouchLibraryLoad)
                 {
-                    LibraryServices.LoadNodeLibrary(assem.Location, false);
+                    LibraryServices.LoadNodeLibrary(assem.Location, isExplicitlyImportedLib: false);
                 }
                 else
                 {
-                    LibraryServices.ImportLibrary(assem.Location);
+                    LibraryServices.ImportLibrary(assem.Location, isExplicitlyImportedLib: false);
                 }
 
                 return;

src/DynamoPackages/PackageLoader.cs

@@ -246,9 +246,11 @@ private void TryLoadPackageIntoLibrary(Package package)
             if (package.LoadState.State == PackageLoadState.StateTypes.Unloaded) return;
 
             List<Assembly> loadedNodeLibs = new List<Assembly>();
+            List<Assembly> failedNodeLibs = new List<Assembly>();
             try
             {
-                // load node libraries
+                List<Assembly> blockedAssemblies = new List<Assembly>();
+                // Try to load node libraries from all assemblies
                 foreach (var assem in package.EnumerateAndLoadAssembliesInBinDirectory())
                 {
                     if (assem.IsNodeLibrary)
@@ -260,11 +262,38 @@ private void TryLoadPackageIntoLibrary(Package package)
                         }
                         catch (LibraryLoadFailedException ex)
                         {
+                            // Managed exception
+                            // We can still try to load other parts of the package
                             Log(ex.GetType() + ": " + ex.Message);
                         }
+                        catch (DynamoServices.AssemblyBlockedException)
+                        {
+                            blockedAssemblies.Add(assem.Assembly);
+                        }
+                        catch (Exception)
+                        {
+                            failedNodeLibs.Add(assem.Assembly);
+                        }
                     }
                 }
 
+                if (loadedNodeLibs.Count > 0)
+                {
+                    // Try to load any valid node libraries regardless package state
+                    PackagesLoaded?.Invoke(loadedNodeLibs);
+                }
+
+                if (blockedAssemblies.Count > 0)
+                {
+                    throw new Exception("The following assemblies are blocked : " + string.Join(", ", blockedAssemblies.Select(x => Path.GetFileName(x.Location))));
+                }
+
+                // Generic fatal error
+                if (failedNodeLibs.Count > 0)
+                {
+                    throw new Exception("Failed to load the following assemblies : " + string.Join(", ", failedNodeLibs.Select(x => Path.GetFileName(x.Location))));
+                }
+
                 // load custom nodes
                 var packageInfo = new Graph.Workspaces.PackageInfo(package.Name, new Version(package.VersionName));
                 var customNodes = OnRequestLoadCustomNodeDirectory(package.CustomNodeDirectory, packageInfo);
@@ -287,7 +316,6 @@ private void TryLoadPackageIntoLibrary(Package package)
 
                 package.SetAsLoaded();
                 PackgeLoaded?.Invoke(package);
-                PackagesLoaded?.Invoke(loadedNodeLibs);
 
                 PythonServices.PythonEngineManager.Instance.
                     LoadPythonEngine(package.LoadedAssemblies.Select(x => x.Assembly));