Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4543 Localize Default Group Styles #12760

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Mar 31, 2022

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

This PR will make sure when launching Dynamo in a localized env, there will be no duplication of default group style entries.

Below is a screenshot in german showing default group styles localized:
image

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Localize default group styles

Reviewers

@DynamoDS/dynamo

FYIs

@QilongTang QilongTang changed the title Initialize group styles from view model Localize Default Group Styles Apr 1, 2022
@QilongTang QilongTang marked this pull request as ready for review April 1, 2022 19:38
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang changed the title Localize Default Group Styles DYN-4543 Localize Default Group Styles Apr 4, 2022
@QilongTang
Copy link
Contributor Author

@QilongTang QilongTang merged commit 922a1e6 into master Apr 4, 2022
@QilongTang QilongTang deleted the GroupStylesInitialization branch April 4, 2022 18:24
QilongTang added a commit that referenced this pull request Apr 4, 2022
* Initialize group styles from view model

* Code clean up

* Clean up

* Update the tests
QilongTang added a commit that referenced this pull request Apr 4, 2022
* Initialize group styles from view model

* Code clean up

* Clean up

* Update the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants