Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-4686 several changes in the group style context menu. #12728

Merged
merged 1 commit into from
Mar 23, 2022
Merged

DYN-4686 several changes in the group style context menu. #12728

merged 1 commit into from
Mar 23, 2022

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Several changes for the AnnotationView context menu for showing group styles and colors.

  • Removed the IsChecked property so is not serialized into the dyn file.
  • Removed the CurrentGroupStyleSelected property due that is was used for the checkmark functionality.
  • All the functionality for checking and unchecking groupstyle menuitems was removed.
  • Removed the checkmark label that was appearing next to the group style.
  • The color contextmenu was moved to be a submenuitem.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Several changes for the AnnotationView context menu for showing group styles and colors.

Reviewers

@reddyashish

FYIs

@QilongTang

- Removed the IsChecked property so is not serialized into the dyn file.
- Removed the CurrentGroupStyleSelected property due that is was used for the checkmark functionality.
- All the functionality for checking and unchecking groupstyle menuitems was removed.
- Removed the checkmark label that was appearing next to the group style.
- The color contextmenu was moved to be a submenuitem.
@RobertGlobant20
Copy link
Contributor Author

This is a GIF of the fix.
groupstyles_updated_contextmenu

@QilongTang
Copy link
Contributor

for

Removed the IsChecked property so is not serialized into the dyn file.

I assume you mean preferences setting xml not dyn?

@QilongTang QilongTang added this to the 2.14.0 milestone Mar 23, 2022
@RobertGlobant20
Copy link
Contributor Author

for

Removed the IsChecked property so is not serialized into the dyn file.

I assume you mean preferences setting xml not dyn?

@QilongTang yes, you are right I was talking about the settings xml file in the GroupStyles section. Thanks

@QilongTang QilongTang merged commit ac5968d into DynamoDS:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants