Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shift + click to nodes and notes to remove from current group #12571

Conversation

johnpierson
Copy link
Member

Purpose

This PR adds shift-click remove from group features to nodes and notes.

2022-01-21.14-22-43.mp4

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Drag adding nodes to groups is awesome. This adds the ability to remove nodes and notes from groups with shift+left click.

Reviewers

@QilongTang

FYIs

@Amoursol

@mjkkirschner
Copy link
Member

just my two cents -

  • how does this work when the node is inside a nested group?
  • automated test would be good to make sure this keeps working though I can see that being difficult.

@johnpierson
Copy link
Member Author

Thanks for taking a look! Nested groups behave how I would expect/want them to. If the node or note is the last in a group it drops the whole group

2022-01-21.14-37-49.mp4

.

@QilongTang
Copy link
Contributor

QilongTang commented Feb 11, 2022

Tested and updated some comments. I found it hard to connect this with a new unit test especially the real-time shift key check. Once the PR check passed, will merge as it is.

@QilongTang QilongTang merged commit 77fe77a into DynamoDS:master Feb 13, 2022
@johnpierson
Copy link
Member Author

😱 oh my gosh. My first real contribution to dynamo's code.

@Amoursol
Copy link
Contributor

😱 oh my gosh. My first real contribution to dynamo's code.

The first of many hopefully dude 💪

@johnpierson johnpierson deleted the featureAdd_shiftClickForRemoveFromGroup_john branch January 17, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants