Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DynamoUnit.xml docs file in Release build #12566

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

saintentropy
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-4531

The release build configuration is missing the DynamoUnit.xml file which means the DynamoUnits ZT nodes will be missing the Description and tooltip information in Dynamo 2.13. This PR fixes that so they will be added.

Note this has already been resolved in the main branch.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • Dynamo Unit ZT nodes have their description and port tooltip documentation restored in the Dynamo UI.

Reviewers

@QilongTang @mjkkirschner

FYIs

@kronz

@QilongTang QilongTang merged commit 940ec27 into DynamoDS:RC2.13.1_master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants