Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash when removing node from group that contains note. #12551

Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix crash when removing node from group that contains note. #12551

merged 1 commit into from
Jan 19, 2022

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Jan 18, 2022 •
edited
Loading

Purpose

https://jira.autodesk.com/browse/DYN-4505

add null check to linq query
add test

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

fix crash when removing node from group that contains note.

@mjkkirschner
fix crash
cb3c9d3 
add test
@QilongTang QilongTang added this to the 1.3.1 milestone Jan 18, 2022
@QilongTang
Copy link
Contributor

LGTM.. And you are quick :)

@mjkkirschner mjkkirschner modified the milestones: 1.3.1, 2.13.1 Jan 18, 2022
@mjkkirschner
Copy link
Member Author

tests are not kicking off currently, so running manually: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/5239/

@mjkkirschner mjkkirschner merged commit c4c8e57 into DynamoDS:master Jan 19, 2022
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Jan 19, 2022
@mjkkirschner
fix crash (DynamoDS#12551)
1bafea1 
add test

Co-authored-by: michael kirschner <[email protected]>
@mjkkirschner mjkkirschner mentioned this pull request Jan 19, 2022
Merged
mjkkirschner added a commit that referenced this pull request Jan 19, 2022
@mjkkirschner
fix crash (#12551) (#12556)
f09fdd8 
add test

Co-authored-by: michael kirschner <[email protected]>

Co-authored-by: michael kirschner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkkirschner @QilongTang