-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Node GetNumber #12332
Add New Node GetNumber #12332
Conversation
Our team can add node icon later but so far I feel this would be a good addition to the existing node base. Thank you for proposing this. |
This is awesome @chuongmep - thank you for submitting this and making Dynamo better! 🙌 |
Regression found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Seems Dynamo SelfServe PR check not triggered correctly for this PR. I am running on demand job at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/917/ and monitoring the results. FYI: @DynamoDS/dynamo |
I see the following regression result, can you take another look?
|
@QilongTang sorry about that, updated. |
@chuongmep Thanks, I have run the self CI again and everything pass now. Once the PR checks are passing, I will merge this |
Purpose
Support Get Number In String.This is very helpful, I have come across forum posts within the past year, users need it for object separation, counting and statistics, checking,...
Node In Action
Declarations
Check these if you believe they are true
Reviewers
@QilongTang @mjkkirschner
FYIs
@Amoursol