Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Greg.dll and Restsharp #12165

Merged
merged 13 commits into from
Oct 20, 2021
Merged

Update Greg.dll and Restsharp #12165

merged 13 commits into from
Oct 20, 2021

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Oct 19, 2021 •
edited
Loading

Purpose

  • Updates Greg.dll (package manager client) and RestSharp references - verified that downloads from DPM are using TLS 1.2 in sandbox.
  • Removes Greg and Restsharp references from LibraryViewExtension - not sure why these were needed - but verified it still builds (even though it is removed from the .sln)
  • Removes RestSharp reference from ViewExtensionLibraryTests

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Oct 19, 2021 •
edited
Loading

self serve:
https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/884/

@mjkkirschner mjkkirschner merged commit b324cce into DynamoDS:master Oct 20, 2021
QilongTang pushed a commit that referenced this pull request Mar 25, 2022
@mjkkirschner @QilongTang
Update Greg.dll and Restsharp (#12165)
03b11f0 
* add null checking to method

* remove greg and rest sharp deps from libraryviewextension

* remove viewextenlibTests ref on restsharp

* updated ref to greg and restsharp - this builds but targets net452 version of restsharp

* update to latest greg version

* revert shared info version

* fix bad merge conflict and bad hint path

* fix

Co-authored-by: michael kirschner <[email protected]>
@QilongTang QilongTang mentioned this pull request Mar 25, 2022
Merged
8 tasks
QilongTang added a commit that referenced this pull request Mar 25, 2022
@QilongTang @mjkkirschner
RestSharp update as Hotfix 2.12.1 (#12739)
03aa73d 
* Update Greg.dll and Restsharp (#12165)

* add null checking to method

* remove greg and rest sharp deps from libraryviewextension

* remove viewextenlibTests ref on restsharp

* updated ref to greg and restsharp - this builds but targets net452 version of restsharp

* update to latest greg version

* revert shared info version

* fix bad merge conflict and bad hint path

* fix

Co-authored-by: michael kirschner <[email protected]>

* Switch to 2019 VS build machine

* Update Build Number

Co-authored-by: Michael Kirschner <[email protected]>
Co-authored-by: michael kirschner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

@sm6srw sm6srw Awaiting requested review from sm6srw

@pinzart90 pinzart90 Awaiting requested review from pinzart90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkkirschner @aparajit-pratap