-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-4215 Forge Unit SDK Nodes #12126
DYN-4215 Forge Unit SDK Nodes #12126
Conversation
# Conflicts: # src/AssemblySharedInfoGenerator/AssemblySharedInfo.cs # src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml # src/LibraryViewExtension/web/library/layoutSpecs.json
(cherry picked from commit 5e8ea77)
src/Libraries/CoreNodeModelsWpf/Controls/DynamoConverterControl.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saintentropy it looks good, but I still have some concerns -
- tests - apologies I just can't remember where we landed on this - but I don't see any tests for the new nodes in this PR?
2. Where are the schema files? I think there should be documentation in this repo regarding them - maybe a readme in the DynamoUnits folder?figured this out, that they are copied from the nuget.
@saintentropy more thoughts: this is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saintentropy a few more comments and some questions - I think it's pretty close, ZT stuff looks pretty good, just questions on nodeModel stuff now.
@saintentropy - I think theres one failing test somehow - https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/4858/testReport/junit/NodeDocumentationMarkdownGeneratorTests/MarkdownGeneratorCommandTests/ProducesCorrectOutputFromCoreDirectory_preloadedbinaries/ though this may be an old build. |
@saintentropy - thanks for fixing the tests - at the moment my only remaining concern is about the NodeType - I guess thats fine for now, but it starts to break down the entire idea of the schema meaning that each nodeType mapped to a very specific set of properties that other clients could count on. Do these nodes have specific properties that are serialized that are consistent with their type? |
@saintentropy - last 3 things I think:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @saintentropy - after tests pass LGTM. I will repoint my test PR to master instead of your fork.
@saintentropy there is one failure on master-15
|
Purpose
https://jira.autodesk.com/browse/DYN-4215
This PR includes new Dynamo Unit nodes based on the ForgeUnitsSDK. They surface the Units category as a top level item in the standard node library and add a set of subcategories which include Quantity, Unit, Symbol, and Utilities. For Quantity, Unit, and Symbols the nodes represent the basic underlying capabilities to defined and associated with these types. Utilities includes helper nodes and UI nodes to work with the basic types.
Description
Quantity Nodes: (ie Length, Mass, etc)
autodesk.unit.quantity:area-1.0.2
)Area
)autodesk.unit.quantity:area-1.0.2
)square feet
,square meters
, etc)Unit Nodes: (ie feet, meters, grams, etc)
autodesk.unit.unit:feet-1.0.1
)feet
)autodesk.unit.quantity:feet-1.0.1
)Symbol Nodes (ie in, ", etc)
autodesk.unit.symbol:in-1.0.1
)in
)autodesk.unit.symbol:in-1.0.1
)Utilities Nodes
Quantities: UI DropDown node with all Quantity types available
Units: UI DropDown node with all Unit types available
Symbols: UI DropDown node with all Symbol types available
Convert Units: Updated UI node that allows specification of a value conversion from one Unit type to another. The UI is the same as the existing which allows specification of a Quantity and Units via drop down but with more supported types.
ConvertByUnitIDs: Zero touch node which allows conversion of a value from one Unit to another (ie 12in to 1ft). The input type is forge typeId string.
ConvertByUnits: Zero touch node which allows conversion of a value from one Unit to another (ie 12in to 1ft). The input type is Unit.
Parse Unit Input: UI Node to allow for string input in the node's text input field which is parsed to a specified double value for a specific Unit (ie 25.4mm string input is converted to 1 with the node set to the Unit feet).
Parse Expression: Zero touch Node to allow parsing of string input math expression to a value (ie "12*2+1" => 25)
Parse ExpressionByUnit: Zero touch Node to allow parsing of string input math expression to a specific unit value (ie "12"*2+1ft" => 3 with the node set to unit feet).
Implementation details... WIP
Todo
Declarations
Check these if you believe they are true
*.resx
filesReviewers
FYIs
@Amoursol @QilongTang @jasonstratton @mjkkirschner