Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark graph modified when group IsExpanded state is changed #12066

Conversation

SHKnudsen
Copy link
Contributor

Purpose

This PR marks the graph as modified when the IsExpanded state is changed.
Related to DYN-3890

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@SHKnudsen SHKnudsen changed the title Update AnnotationViewModel.cs Mark graph modified when group IsExpanded state is changed Sep 27, 2021
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add a unit test for it?

@SHKnudsen
Copy link
Contributor Author

@QilongTang added a test for this

@QilongTang
Copy link
Contributor

@SHKnudsen Perfect. Waiting for unit test pipeline to pass before merging.

@QilongTang
Copy link
Contributor

The regression failure test is due to other changes by our team, merging

@QilongTang QilongTang merged commit df20cc1 into DynamoDS:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants