Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-3777: disable linter choice in forbidden workspaces #11759

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

BogdanZavu
Copy link
Contributor

Purpose

For now, we will only allow users to change Linter in HomeWorkspaceModels. This is temporary and we will remove this limitation in the near future.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@mjkkirschner
Copy link
Member

Can a user get into a situation where they open a custom node which is somehow set to the wrong linter and it cannot be disabled?

@BogdanZavu
Copy link
Contributor Author

That should not be possible just yet, you can't set an active linter for a custom node workspace. Also, there is no "link" against a custom node workspace model and no processing will occur.

@saintentropy
Copy link
Contributor

LGTM @BogdanZavu

@BogdanZavu
Copy link
Contributor Author

The test failure is unrelated to this change and it passed when the build was triggered manually from Jenkins.

@BogdanZavu BogdanZavu merged commit 358809c into DynamoDS:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants