Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Helix to 2.16.1 #11752

Merged
merged 5 commits into from
Jun 17, 2021
Merged

Upgrade Helix to 2.16.1 #11752

merged 5 commits into from
Jun 17, 2021

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Jun 14, 2021

Purpose

DYN-3769: Dynamo freeze/crash multiple screen or display resolution.

This pull request does:

  • upgrade helix to version 2.16.1.
  • update two tests to use the new API in 2.16 for accessing textures from the texture cache (textures are not a member of the TextureModel anymore).

Helix 2.16 also have breaking API changes to low level hit methods but these are not directly used by Dynamo.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw added the WIP label Jun 14, 2021
@sm6srw sm6srw changed the title WIP: Upgrade helix to 2.16 WIP: Upgrade helix to 2.16.1 Jun 14, 2021
@sm6srw sm6srw changed the title WIP: Upgrade helix to 2.16.1 Upgrade Helix to 2.16.1 Jun 16, 2021
@sm6srw sm6srw removed the WIP label Jun 16, 2021
@sm6srw sm6srw merged commit d45f96c into DynamoDS:master Jun 17, 2021
@sm6srw sm6srw deleted the DYN-3729 branch June 17, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants