Add dropdown to package preferences dialog for package paths for download

[aparajit-pratap]

Purpose

DYN-3723: Add a dropdown to list all package paths where packages can be downloaded.

WIP:

• Avoid hardcoding Dynamo version for AppData path
• Filter out paths to file names from custom package paths to display in dropdown
• Add property changed event for changing selected path for analytics and in order to update label and tooltip in preferences dialog
• Use selected package path to tell package manager client to download packages to that path
• Add tooltip displaying full path for long paths cut off from dropdown display
• Add unit test to verify downloading package to path chosen by simulating selection from dropdown
• UI Automation tests

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate (WIP)
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated

FYIs

@QilongTang
@Amoursol
@Jingyi-Wen

[mjkkirschner]

@aparajit-pratap relative to the design - it looks like we're missing this label.

[aparajit-pratap]

@aparajit-pratap relative to the design - it looks like we're missing this label.

Yes, I had seen this but I didn't quite understand why there was one label underneath another unless the Node and Package Paths label is the title for the page overall. @Jingyi-Wen?

[mjkkirschner]

@aparajit-pratap node and package paths is the expander/title for the section. It includes both the dropdown to set a specific download path, as well as the search paths - each of those sub sections have a label.

Then there is another expander/section for the installed packages.

[aparajit-pratap]

@aparajit-pratap node and package paths is the expander/title for the section. It includes both the dropdown to set a specific download path, as well as the search paths - each of those sub sections have a label.

Then there is another expander/section for the installed packages.

Ok, I got it now. That clears my confusion. I was wondering where the Package/Library Search Paths section disappeared in the mockups. I thought that was an expander by itself, didn't realize it was part of the Node and Package Paths expander.

[aparajit-pratap]

@Jingyi-Wen for the New Package Download Directory label, I've used the same style as the Default Python Engine label, however, I notice that the font size of these labels is bigger than the respective expander labels. I feel that the expander label being a top-level label should have a higher font size.

[Jingyi-Wen]

@Jingyi-Wen for the New Package Download Directory label, I've used the same style as the Default Python Engine label, however, I notice that the font size of these labels is bigger than the respective expander labels. I feel that the expander label being a top-level label should have a higher font size.

@aparajit-pratap Great catch! We were using the same font size but different thickness(bold vs semi-bold vs regular) to visually indicate levels in the design. We might need to adjust the thickness for item labels and expander labels

[mjkkirschner]

@Jingyi-Wen @aparajit-pratap - another thought here - when a really long package download path is selected it appears like it's getting cut off - which makes sense since the dialog width is fixed.

Can we do something like if you hover over the path the tooltip shows the full path?

I think addressing @QilongTang wanted to address making the dialog resizable later after 2.12.

[aparajit-pratap]

@Jingyi-Wen @aparajit-pratap - another thought here - when a really long package download path is selected it appears like it's getting cut off - which makes sense since the dialog width is fixed.

Can we do something like if you hover over the path the tooltip shows the full path?

I think addressing @QilongTang wanted to address making the dialog resizable later after 2.12.

Yeah, I was thinking the same thing about having the tooltip. I'll try to add it.

[Jingyi-Wen]

@Jingyi-Wen @aparajit-pratap - another thought here - when a really long package download path is selected it appears like it's getting cut off - which makes sense since the dialog width is fixed.
Can we do something like if you hover over the path the tooltip shows the full path?
I think addressing @QilongTang wanted to address making the dialog resizable later after 2.12.

Yeah, I was thinking the same thing about having the tooltip. I'll try to add it.

Thank you! That sounds good. I thought about this but missed it in mockup, adding it now

[mjkkirschner]

@aparajit-pratap - this looks really solid, just a few comments besides the ones inline.

• looks like some conflict from a recent pr.
• unit tests for the new property getters, and preference setting would be good I think.

[pinzart90]

If this font is supposed to be re-used in other parts of the UI, maybe we can store it in the styles xaml ?

[mjkkirschner]

I have added a style for this now, we can clean it up later though after these all get merged.

[pinzart90]

LGTM

[mjkkirschner]

a few small comments - probably not blockers.

[mjkkirschner]

I have added a style for this now, we can clean it up later though after these all get merged.

[mjkkirschner]

what if this returns -1, is that acceptable?

[aparajit-pratap]

It was being assigned -1 even before, the core logic is the same as before so I didn't think much about it.

[mjkkirschner]

are these strings possibly already defined somewhere?

[aparajit-pratap]

These probably should be defined as constants somewhere as they are hardcoded in several places throughout the codebase. I'm not doing it here as it could clutter this PR.