-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages expander panel in the Workspace References panel #11744
Conversation
@Jingyi-Wen Did we finalize where the refresh button should be, e.g on expander or inside? Or let me put it this way, is the current way shown by @reddyashish fine to proceed for now :) |
@QilongTang @Jingyi-Wen As I am using the same expander styling used in preferences panel, I had left the refresh button where it was before for now. It might get little tricky to place it inside the expander but if you think that would be better, I can look into some solution. |
Cool, I dont have a preference for this one. |
I was a little bit hesitant about the same thing. I think this current location looks good. Let's not risk messing up with the expanding behavior then |
src/WorkspaceDependencyViewExtension/WorkspaceDependencyView.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Task: https://jira.autodesk.com/browse/DYN-2218
This PR is to create Packages expander and extend that to non-package dependencies.
TODO:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo