Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update List.IndexOf node description #11735

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Update List.IndexOf node description #11735

merged 2 commits into from
Jun 7, 2021

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 6, 2021

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Per customer request, updating node description for List.IndexOf node. See UI change below (notice word hard was later refactored to be strict):

image

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo @Amoursol

FYIs

@QilongTang
Copy link
Contributor Author

@Amoursol @aparajit-pratap Addressed the comments. If looks good, please approve.

@QilongTang QilongTang merged commit 6cadc95 into master Jun 7, 2021
@QilongTang QilongTang deleted the UpdateListIndexOf branch June 7, 2021 16:49
@Amoursol
Copy link
Contributor

Amoursol commented Jun 7, 2021

LGTM @QilongTang - did you need me to officially commit my review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants