Add Python dependency info to packages and display it in DPM UI #11731
Conversation
…11611) * display dep info * comments
| @@ -1255,6 +1255,10 @@ | |||
| <Project>{6e0a079e-85f1-45a1-ad5b-9855e4344809}</Project> | |||
| <Name>Units</Name> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\Libraries\PythonNodeModels\PythonNodeModels.csproj"> | |||
| <Project>{8872CA17-C10D-43B9-8393-5C5A57065EB0}</Project> | |||
| <Name>PythonNodeModels</Name> | |||
There was a problem hiding this comment.
While I don't think this causes a circular dependency, it is a bit odd to have DynamoCoreWPF depend on a node library.
If we could figure out a way to solve this with reflection or some other mechanism - for example an interface in DynamoServiecs that might better decouple the core from our libraries and make it clear what the required interfaces actually are.
There was a problem hiding this comment.
On the other hand, one could make the argument that this is now a core requirement for a UI feature and as such we need to have this reference.
You may want to spend more time generalizing this if we still intend to allow for fully dynamic python engine loading in the future (theres a bunch of places that would need to be improved, and this is just one more) - if not, then maybe defining those interfaces is not worth it at the moment.
There was a problem hiding this comment.
@mjkkirschner I feel the problem can be traced back to why package manager UI is part of DynamoCoreWpf. To me it seems PM should be more a view extension but not the current way that UI in CoreWpf but data model as extension.. On that note, if the original design is that PM should be part of Core then I feel this dependency is accurate.. Or we could move Python loading to DynamoCore but that also seems not necessary.
There was a problem hiding this comment.
@QilongTang - there is actually a PackageManagerUIViewExtension - we just never finished moving the UI out of core and into the view extension :) - more tech debt.
There was a problem hiding this comment.
Ah.. @mjkkirschner Then are you fine of this temp dependency and we shall get to it. Our team have Package Manager UI refresh this quarter and it seems the tech debt can be address in that epic?
There was a problem hiding this comment.
sounds good - maybe we just make a jira task for this (python references) and another for the packageManager UI refactor tech debt to track both of them?
There was a problem hiding this comment.
|
@zeusongit @QilongTang - I see the tests are failing - my guess is because some python assemblies are being copied to multiple folders now because of the new references. mark it private false or add a cleanup target to one of the scripts we have to delete those binaries. |
Purpose
https://jira.autodesk.com/browse/DYN-3643
PS: One time process to scan and update all existing packages is under development.
SS:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo