-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-3738: enhance readyparams api #11726
Conversation
Hi @BogdanZavu, thank you for addressing the comments. There are times we do break the API and document it like you originally had done. But this should only be done when theres no good alternative solution that does not break the API - or there is good enough reason to intentionally break an API. For example - we broke (and probably will again) the Helix 3d graphics APIs within a minor release:
In general I think principles like this should be used to judge API breaks.
|
public event Action<IWorkspaceModel> CurrentWorkspaceClearingStarted; | ||
private void OnCurrentWorkspaceModelClearingStarted(IWorkspaceModel ws) | ||
{ | ||
if (CurrentWorkspaceClearingStarted != null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in newer c# versions we can now do this:
CurrentWorkspaceClearingStarted?.Invoke(ws);
I was thinking of this more as a fix rather than an API change. Whoever subscribes to the clearing event most likely will get the workspace from somewhere else. |
Purpose
Enhance existing ReadyParams API so that we can have better control over graph opening and closing operations as part of an extension. We will use this in LintingViewExtension where we want to do some cleanup when a graph is closed and allow an extension developer to perform cleanup operations on their listing rules.
Declarations
Check these if you believe they are true
*.resx
files