Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the new IF node. #11721

Merged

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented May 28, 2021

Purpose

This PR is to add tests around Lacing, ListAtLevel and Partial function features for the new IF node

There are some tests in "IfTest" fixture that are testing the old "IF" node. Do we want to keep them around to support the old node or do we plan to replace the tests with the new node?

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@aparajit-pratap @QilongTang

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM What do you think @aparajit-pratap

@reddyashish
Copy link
Contributor Author

reddyashish commented Jun 2, 2021

@aparajit-pratap Merging this for now and will create a merge PR from this branch to master to get new IF node changes. Let me know if you of any changes and I will look into it.

@reddyashish reddyashish merged commit fb2e213 into DynamoDS:RefactoredIfNode Jun 2, 2021
@reddyashish reddyashish mentioned this pull request Jun 2, 2021
8 tasks
@reddyashish reddyashish deleted the RefactoredIfNode branch November 23, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants