-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Double Left Click to trigger NodeAutoComplete #11710
Conversation
owningWorkspace.CurrentCursor = CursorLibrary.GetCursor(CursorSet.ArcSelect); | ||
owningWorkspace.IsCursorForced = false; | ||
return true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting the old code handling Alt+ mouse left click to trigger node Autocomplete
<!--Bind NodeAutoComplete to double left click--> | ||
<Grid.InputBindings> | ||
<MouseBinding MouseAction="LeftDoubleClick" Command="{Binding Path=NodeAutoCompleteCommand}"></MouseBinding> | ||
</Grid.InputBindings> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bind NodeAutoComplete to double left click here using Grid.InputBindings
since Grid does not expose double left click event directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you think any unit tests need to be changed?
I will wait for the self serve to finish. I think the unit tests were using view command directly so we may be fine there but good points! |
All unit tests passing, merging |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
As an alternative to #11709, use double left mouse click to trigger NodeAutoComplete instead of Alt + mouse left click. This end up being a cleaner implementation.
FYI: @Amoursol
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of