Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-3529: Migrate clr.AddReferenceToFileAndPath() to clr.AddReference() in python migration tool #11708

Merged
merged 3 commits into from
May 26, 2021

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented May 24, 2021

Purpose

DYN-3529: Migrate clr.AddReferenceToFileAndPath() to clr.AddReference() in python migration tool

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@mjkkirschner
Copy link
Member

mjkkirschner commented May 25, 2021

@sm6srw LGTM - though were you able to check if this pythonNet function is a good replacement for the ironPython function? Will it import arbitrary python files from a path?

@mjkkirschner mjkkirschner self-requested a review May 25, 2021 14:10
@sm6srw
Copy link
Contributor Author

sm6srw commented May 25, 2021

@sm6srw LGTM - though were you able to check if this pythonNet function is a good replacement for the ironPython function? Will it import arbitrary python files from a path?

I am playing around with that now.

@sm6srw sm6srw merged commit 0eb7f14 into DynamoDS:master May 26, 2021
@sm6srw sm6srw deleted the DYN-3529 branch May 26, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants