-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics Change for Preferences View #11696
Conversation
Dynamo.Logging.Analytics.TrackEvent( | ||
Actions.Switch, | ||
Categories.Preferences, | ||
Res.PreferencesViewLanguageLabel); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pattern introduce some repeated code but will be most accurate to avoid logging dialog initialization
Dynamo.Logging.Analytics.TrackEvent( | ||
Actions.Switch, | ||
Categories.Preferences, | ||
description); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of logging is more code efficient.. But can't seem to rule out the cases for dialog initialization, because in those cases Dynamo raise property changes regardless if it's user change.. Will look a bit more on best way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back, since Model_PropertyChanged
bind after dialog initialization, this approach should be accurate
@@ -552,10 +552,6 @@ | |||
<value>Number Format</value> | |||
<comment>Setting menu | Number format</comment> | |||
</data> | |||
<data name="DynamoViewSettingMenuRenderPrecision" xml:space="preserve"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is duplicate of PreferencesViewVisualSettingsRenderPrecision
. @RobertGlobant20 @Astul-Betizagasti when you have time, let's review the resource strings we touched and make sure no duplicates were left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After some thoughts on expanders, seems tracking the clicking there provide minimum value to us. I feel it is reasonable to leave out as part of this PR because at least all working controls in preferences panel works already. |
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Analytics Change for Preferences View.
This PR covers analytics for the following area
TODO: Should we track actions on expanders?
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of