Added node-autocomplete documentation #11690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| private void OnMoreInfoClicked(object sender, RoutedEventArgs e) | ||
| { | ||
| ViewModel.dynamoViewModel.OpenDocumentationLinkCommand.Execute(new OpenDocumentationLinkEventArgs(new Uri(Dynamo.Wpf.Properties.Resources.NodeAutocompleteDocumentationUriString, UriKind.Relative))); |
There was a problem hiding this comment.
is there a pattern you are following for adding this to the resx file?
I hope this does not get localized - that would cause problems wouldn't it?
There was a problem hiding this comment.
yes it's done the same way for Python editor documentation and publish package doc as well
There was a problem hiding this comment.
@QilongTang it might be worth checking with localization team if this is going to cause a problem - if the url is localized then this link won't work in localized environments. (I think)
There was a problem hiding this comment.
@mjkkirschner Thanks, I have reached out to localization team. https://autodesk.slack.com/archives/C01FVCEMYTA/p1621415985002200
QilongTang
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added an icon to display doc browser with node autocomplete documentation
Update: Added GIFs (Total size: 162KB of 3 gifs/images)
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo