-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Helix Toolkit from 2.11 to 2.15 #11658
Conversation
I must be misunderstanding that PR - because it still looks like the behavior is to create a buffer(vertexCount) ? Also since the default for |
@mjkkirschner for our purposes the new The original local |
The |
It looks good to me, but it's probably good to run the view comparison tests. |
Image comparisons are pass @mjkkirschner @aparajit-pratap |
Purpose
This PR is to update the Helix Toolkit (and by association the Cyotek.Drawing.BitmapFont dependency) from version 2.11 to version 2.15. The purpose of this PR is to address a memory optimization related to the #11395 PR (Generating a single render package per node). Specifically the helix-toolkit/helix-toolkit#1494 PR modifies the behavior of the
VertexArrayBuffer
which was being retained in memory as a sparse array based on the largest size mesh to be rendered in the session. In 2.15 this buffer is not pinned to the largest allocation size in session.As a point of interest. This Helix PR fix was triggered due to the issue filed by @aparajit-pratap. helix-toolkit/helix-toolkit#1449
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@aparajit-pratap @mmisol
FYIs
@mjkkirschner