Fix node autocomplete suggetions on custom nodes #11653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Apr 29, 2021
| @@ -430,6 +430,16 @@ internal string GetInputPortType() | |||
| return type; | |||
| } | |||
|
|
|||
| var cusNode = Owner as CustomNodes.Function; | |||
| if (cusNode != null) | |||
There was a problem hiding this comment.
I think @mjkkirschner suggested to use a is check on @reddyashish 's PR, you may want to give it a try to simplify the code as well here
|
@zeusongit Would you take a look as to what is failing on self serve? I dont think this would affect existing unit tests but let's confirm that. Otherwise, looks good to me |
QilongTang
approved these changes
Apr 30, 2021
reddyashish
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The node-autocomplete feature was unable to identify the input type for custom nodes, thereby displaying default suggestions for all custom node inputs. That was fixed by casting node model to appropriate custom node class and extracting the type info of the input port to be used by the node-autocomplete search.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo