-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Node Autocompletion for output ports of Dynamo nodes. #11638
Conversation
@reddyashish maybe when nothing matches we show a list with codeblock, watch node, or python? |
Due to the convenience of creating CBN, I would maybe just add watch, watch 3D and Python, even watch3D may not be universal. My 2 cents. |
@mjkkirschner @QilongTang Addressed the comments. |
/// <summary> | ||
/// Class for all Auto-Completion Node search elements. | ||
/// </summary> | ||
public abstract class AutoCompletionNodeSearchElement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-iterate the purpose of this class by comments here? We cant inherit the NodeSearchElement class because auto-completion API returns a list of NodeSearchElement and we would need this information in the NodeSearchElementViewModel to connect the port? I am fine with this, @mjkkirschner @aparajit-pratap what do you think? I think we plan to keep expanding here because we will have more properties coming in specific to AutoComplete function, e.g. user's rank, whether favored, ML rank
Purpose
This PR is to address the task: https://jira.autodesk.com/browse/DYN-3344
This PR will enable the node autocompletion functionality on the output ports of the nodes. The node autocompletion model will find all the matching nodes which has atleast one input parameter matching the output port type of the selected node. When any of the search elements are clicked, it will create the node and connect the output port of the original node to the first available matching input port of the new node.
Things to discuss
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@QilongTang @zeusongit @mjkkirschner @aparajit-pratap