-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-3572 std.lib should be visible in manage node and package path UI #11622
Conversation
src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/PackagePathViewModel.cs
Outdated
Show resolved
Hide resolved
this is actually covered in: but fixing it now is even better. I think it may ultimately change, but it's good to make it as correct as possible IMO. |
@sm6srw - theres one AC that was included in the task that I don't see in your description: |
This looks pretty solid to me - one thought that occurs to me is that depending on our final strategy for dealing with conflicts during package install (as opposed to Dynamo startup) - that we may reevaluate std.lib's location (first or last), additionally feedback from UX may lead us to rethink this anyway. Given that, do you think the position is difficult to change after this PR or it will be pretty straightforward? - I was wondering if the logic could be abstracted into a position field somewhere we could set. |
Thanks, I missed this one. I will take a look. |
It is a small change. It happens in two places right now. But I have been thinking that it might be possible to remove that logic all together now from the |
Purpose
DYN-3572 std.lib should be visible in manage node and package path UI
Note: This will also fix DYN-3570 and partially fix DYN-3571 as it will stop Packet manager from downloading packages to the Standard Library directory (but it is till possible to download to the
%ProgramData%
directory).This pull request does:
PathManager
.DynamoModel
.DynamoModel
.Standard Library
to the resources inPackagePathViewModel
so it can be translated.Standard Library
resource when the dialog initializes.PackagePathViewModel
.PackagePathViewModel
.Standard Library
resource with the standard library token when changes are committed in the dialog.DefaultPackagesDirectory
property points to the first non standard library entry inPackageLoader
PackageLoader
PackageLoader
Normal dialog:
Dialog when Standard Library is disabled:
Declarations
Check these if you believe they are true
*.resx
files