Update NodeAutocomplete search criteria to also include nodes keywords and description #11613
Conversation
|
Is there a reason this uses its own search instead of the search code that already exists for in canvas and library search? |
|
@zeusongit Did you made any comparison of in-canvas search yet? I am not sure if string comparison of these three cates will be a 100% match, I think originally we were leaning towards to just reuse the existing search code in in-canvas search. |
|
@mjkkirschner The in canvas and library searches are conducted on complete set of nodes, whereas this is done on a subset of that, which is defined by the target input port i.e all the nodes which are compatible with it. |
| @@ -349,7 +349,7 @@ public void SearchNodeAutocompletionSuggestions() | |||
|
|
|||
| // Filter the node elements using the search field. | |||
| searchViewModel.SearchAutoCompleteCandidates("ar"); | |||
| Assert.AreEqual(2 , searchViewModel.FilteredResults.Count()); | |||
| Assert.AreEqual(4 , searchViewModel.FilteredResults.Count()); | |||
There was a problem hiding this comment.
@zeusongit Looks like the number diff is expected due to?
There was a problem hiding this comment.
Because the search term ar now returns more than 2 results as the search scope has been increased to cover description and keywords.
DYN-3357
The node-autocomplete search used only the node name to match the search key. It has been updated to include node's keywords and description as well.
In the example below
radiusis the search key that is present inByFilletnode's description and therefore did not use to appear in the search results before.Before:
After:
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo