Address Unsaved Changes Edge Case #11601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Per https://jira.autodesk.com/browse/DYN-1764, deleting a node with no connection or deleting a node which is the right end edge of the graph does not make the graph
HasUnsavedChanges = true
. This is due to the code in undoredo recorder to mute node modified to prevent flooding, see https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCore/Graph/Workspaces/UndoRedo.cs#L236After some consideration, I decided to append this step to node removing step to make sure it is always done. Let me know if you have better thoughts.
Before:
After:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of