Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Autocomplete first time experience Update #11593

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Apr 6, 2021

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

First time Dynamo users will get the following gallery of Dynamo introduction. Starting from Dynamo 2.12.0, Node Autocomplete will become the first page.
image

Screenshot designed by @Jingyi-Wen

Let me know if you have any suggestions for description to cover.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

FYIs

FYI: @Amoursol @mjkkirschner

@zeusongit
Copy link
Contributor

Just curious, is it possible to get a gif on this page?

@QilongTang
Copy link
Contributor Author

Just curious, is it possible to get a gif on this page?

Sure, here is how to trigger it if you copy the content to the right folder locally. Usually this i done by Dynamo integrators. To fake a first launch of Dynamo, one need to touch preference setting but I did not bother doing it. The following gif shows how to access it manually. For first time user, gallery will launch it self when using Dynamo
NodeAutoCompleteGallery

@zeusongit
Copy link
Contributor

Just curious, is it possible to get a gif on this page?

Sure, here is how to trigger it if you copy the content to the right folder locally. Usually this i done by Dynamo integrators...

Sorry, I meant that instead of a static image on the startup screen, can we get a gif of the node autocomplete in action?

@QilongTang
Copy link
Contributor Author

Just curious, is it possible to get a gif on this page?

Sure, here is how to trigger it if you copy the content to the right folder locally. Usually this i done by Dynamo integrators...

Sorry, I meant that instead of a static image on the startup screen, can we get a gif of the node autocomplete in action?

hi @zeusongit , I gave it a try and the gallery view in Dynamo does not support gif. Also searched online, there is no built in support for gif in WPF. In gallery view, we are using image control which does not support gif OOTB

Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang
Copy link
Contributor Author

The self serve is failing due to known issues. Merging

@QilongTang QilongTang merged commit b6274eb into master Apr 8, 2021
@QilongTang QilongTang deleted the NodeAutoCompleteGalleryUpdate branch April 8, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants