Extension data to home workspace #11553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storing-user-defined-Graph-documentation
mjkkirschner
approved these changes
Mar 19, 2021
mjkkirschner
pushed a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Mar 19, 2021
* workspacemodel thumbnail api + test * add graphDocumentationURL + serialise and deserialise Author * Update WorkspaceModel.cs * handle empty URIs * Update 2080_JSONTESTCRASH undo_redo.dyn * move thumbnail and help link to HomeWorkspaceMode * move extension data to HomeWorkspaceModel
mjkkirschner
added a commit
that referenced
this pull request
Mar 20, 2021
* Extension data to home workspace (#11553) * workspacemodel thumbnail api + test * add graphDocumentationURL + serialise and deserialise Author * Update WorkspaceModel.cs * handle empty URIs * Update 2080_JSONTESTCRASH undo_redo.dyn * move thumbnail and help link to HomeWorkspaceMode * move extension data to HomeWorkspaceModel * merge conflicts, remove new properties Co-authored-by: Sylvester Knudsen <[email protected]> Co-authored-by: michael kirschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Moves ExtensionData to the HomeWorkspaceModel
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mjkkirschner
FYIs
@saintentropy @nate-peters