Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document experience marking node libraries when publishing a package in Documentation browser #11539

Merged
merged 10 commits into from
Mar 19, 2021

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Mar 11, 2021

Purpose

Added documentation related to publishing a package to Package manager inside dynamo.
Can be triggered clicking an icon on the publish package dialog box.

pubgif

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

@mjkkirschner
Copy link
Member

this looks really nice!

@zeusongit zeusongit marked this pull request as ready for review March 17, 2021 13:52
Copy link
Contributor

@Amoursol Amoursol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments in-line @zeusongit ! :)

@zeusongit
Copy link
Contributor Author

Thank you @Amoursol for the review, I have made the changes as requested.

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one comment, looks solid

@aparajit-pratap
Copy link
Contributor

Does this documentation describe how package authors can add package dependencies like @LongNguyenP was requesting for DynaShape?

@QilongTang
Copy link
Contributor

Does this documentation describe how package authors can add package dependencies like @LongNguyenP was requesting for DynaShape?

No, plus Long is using a work around. I would be hesitate to add that until we support it on the publish UI. The documentation here is meant to cover all operations user can do on the publish dialog

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@zeusongit zeusongit merged commit 7a06adf into DynamoDS:master Mar 19, 2021
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Mar 23, 2021
zeusongit added a commit that referenced this pull request Mar 23, 2021
…ublishing a package in Documentation browser. (#11564)

* cherry-pick #11539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants