-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document experience marking node libraries when publishing a package in Documentation browser #11539
Conversation
this looks really nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments in-line @zeusongit ! :)
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
src/DynamoCoreWpf/ViewModels/PackageManager/Docs/PublishPackageDocumentation.html
Outdated
Show resolved
Hide resolved
Thank you @Amoursol for the review, I have made the changes as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than one comment, looks solid
Does this documentation describe how package authors can add package dependencies like @LongNguyenP was requesting for DynaShape? |
No, plus Long is using a work around. I would be hesitate to add that until we support it on the publish UI. The documentation here is meant to cover all operations user can do on the publish dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge
Purpose
Added documentation related to publishing a package to Package manager inside dynamo.
Can be triggered clicking an icon on the publish package dialog box.
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo