set IsFirstRun to false if hide report options is true #11530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
changed the title
QilongTang
reviewed
Mar 8, 2021
| @@ -914,6 +914,11 @@ private void DynamoView_Loaded(object sender, EventArgs e) | |||
| // If first run, Collect Info Prompt will appear | |||
| UsageReportingManager.Instance.CheckIsFirstRun(this, dynamoViewModel.BrandingResourceProvider); | |||
There was a problem hiding this comment.
It's a bit hard to understand from first glance, to me it seems we may want to fold the dynamoViewModel.HideReportOptions check into CheckIsFirstRun() at https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCoreWpf/Services/UsageReportingManager.cs#L154 so we do not skip the check/setting FirstRun entirely but only skip the usage prompt
There was a problem hiding this comment.
@QilongTang let me give that a shot.
|
@QilongTang PTAL |
QilongTang
approved these changes
Mar 8, 2021
|
@mjkkirschner I think this one will need cherry-pick right? |
|
doing it now 😉 |
mjkkirschner
added a commit
to mjkkirschner/Dynamo
that referenced
this pull request
Mar 8, 2021
* Update DynamoView.xaml.cs * add test add internal setter * review comments Co-authored-by: michael kirschner <[email protected]>
mjkkirschner
added a commit
that referenced
this pull request
Mar 8, 2021
* Update DynamoView.xaml.cs * add test add internal setter * review comments Co-authored-by: michael kirschner <[email protected]> Co-authored-by: michael kirschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
when
hide report optionsis enabled, the prompt to request user analytics is also hidden - this function has the side effect thatIsFirstRunis set to false so the gallery is not shown again.If
hide report optionsis enabled we setIsFirstRunto false after this check, but before trying to raise a gallery window.TODO
Declarations
Check these if you believe they are true
*.resxfiles