Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new version of python net #11508

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Update to new version of python net #11508

merged 3 commits into from
Feb 19, 2021

Conversation

sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Feb 18, 2021

Purpose

This PR will bump pythonnet to version 2.5.1.7. This is related to DYN-3476.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

@sm6srw sm6srw changed the title [WIP] Update to new version of python net Update to new version of python net Feb 19, 2021
@mjkkirschner
Copy link
Member

mjkkirschner commented Feb 19, 2021

@sm6srw what about the references to Python.Included:

<Reference Include="Python.Included, Version=2.5.0.0, Culture=neutral, processorArchitecture=MSIL">

also I may have lead you astray - do we also need to update the python.Runtime.dll? Where is that coming from?

reference here:

<Reference Include="Python.Runtime, Version=2.4.1.0, Culture=neutral, processorArchitecture=MSIL">

Copy link
Member

@mjkkirschner mjkkirschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment about other references in the DSCPython project.

@sm6srw
Copy link
Contributor Author

sm6srw commented Feb 19, 2021

see above comment about other references in the DSCPython project.

It works without changing them (they are both out of sync as it is already) but I will go ahead and update them.
I searched for the old reference, now I know why I only found a reference in test project.
Thanks for catching this.

@sm6srw sm6srw merged commit c1fe271 into DynamoDS:master Feb 19, 2021
@sm6srw sm6srw deleted the DYN-3476 branch February 19, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants