Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-3343] Automatically add loaded packages as crash detail #11500
[DYN-3343] Automatically add loaded packages as crash detail #11500
Changes from 51 commits
1319780
c78dfe9
e446a29
a361a67
f4d5c44
1b91432
4944efb
edf927d
efee990
948b39f
ea4dce4
a8b38cc
ec787fa
7f1c3a5
a0461d6
d2ebf09
d96a729
b0f8162
714fe11
3a126b5
02eda71
391876c
a5efddc
074953f
de03f79
b6e27c2
fb440d5
053995d
052efea
8b71a46
b58c205
631462e
90b5e82
ff0d9c9
ae28659
66233a8
c1e51ec
3f5e4a6
21457f9
3588f40
d6a4d8b
8a60f0e
2daeaa7
942158f
cbced46
3b9e275
839f05f
0da6573
2cc79e0
7298926
f31b2d1
5d73798
78bbea2
c06405e
ca69f53
a1cfbd2
2e663eb
aaa2229
8de2a98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assert below that
decoded
contains package info. And also make a new test that covers the default state of the APIThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the change suggested on the test, but can you expand on the other test you mentioned? The API should work the same as before the changes with the exception of it including more information (which is being checked on that test you linked with the changes you suggested). Are you referring to the method
PackagesToMakrdown(PackageLoader packageLoader)
in CrashUtilities.cs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I would like a test covering the default state so we can assert the API defaults to
No loaded packages were found.