Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkboxes to select node libraries #11462

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Feb 8, 2021

Purpose

Changes the publish package dialog to use checkboxes rather than a
context menu to select which dlls are node libraries. Also adds an
instructive text on top to further guide users.

Snapshot:
Screen Shot 2021-02-08 at 9 45 09 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Changes the publish package dialog to use checkboxes rather than a
context menu to select which dlls are node libraries. Also adds an
instructive text on top to further guide users.
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Curious if you had the chance to test it locally to check if the pkg.json has IsNodeLib set correctly

@mmisol
Copy link
Collaborator Author

mmisol commented Feb 8, 2021

@QilongTang I tested it but I had to do some code changes to run it outside Revit (had some errors otherwise) and also avoid the actual publishing. It should be equivalent to actual usage I think.

@QilongTang
Copy link
Contributor

@QilongTang I tested it but I had to do some code changes to run it outside Revit (had some errors otherwise) and also avoid the actual publishing. It should be equivalent to actual usage I think.

Great!

@mmisol mmisol merged commit a5e250a into DynamoDS:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants