Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update licenses and about box for 2.10 and master branch changes #11408

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

mjkkirschner
Copy link
Member

Purpose

PR does the following:

  • adds references that were missed for pythonmigration extension
  • adds references used in markdown2html.exe project
  • removes old reference to msvc redistributable for 2013
  • updates license pointer for xceed wpf to version that we reference were the license was still MS-PL - NOTE! we will not be able to update this dependency without investigating the new license. beware. ⚠️
  • updates the link styling in the rtf doc so all the links now appear blue, highlight subtly, and open a browser.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

also to license.rtf - fix link styling in word so rtf dialog has working unified links!
point to license for xceedwpf for the version we reference.
LICENSE.txt Outdated
### AngleSharp
https://github.com/AngleSharp/AngleSharp
https://github.com/AngleSharp/AngleSharp/blob/master/LICENSE
(MIT license)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the alignment matter here? Looks off

LICENSE.txt Outdated
### HTMLSanitizer
https://github.com/mganss/HtmlSanitizer
https://github.com/mganss/HtmlSanitizer/blob/master/LICENSE.md
(MIT license)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@mjkkirschner mjkkirschner merged commit 9679c6d into DynamoDS:master Jan 19, 2021
@mjkkirschner mjkkirschner deleted the updatelic branch January 19, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants