Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DynamoSample file to Revit 2022 #11381

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

ZiyunShang
Copy link
Contributor

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Upgrade Revit Sample file to Revit 2022

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @mjkkirschner

FYIs

@Amoursol

@ZiyunShang
Copy link
Contributor Author

I think this change should be cherry picked to RC2.10.0_master branch. And may need a new package of DynamoVisualProgramming.DynamoSamples.

@QilongTang
Copy link
Contributor

hi @ZiyunShang unfortunately 2.10.0 is out already so cherrypicking now may not affect the nugets we publish, if you need to consume we can use some workaround..

@ZiyunShang
Copy link
Contributor Author

Hi @QilongTang , we need the new rvt file in the Revit 2022 installation. I think the new nugets package is necessary.

@QilongTang
Copy link
Contributor

@ZiyunShang Understand, would you mind using the 2.11.0 beta nugets in this case, there should be no difference. It is currently unclear if our team will need to point release 2.10.0 again so the fastest way is to leverage 2.11.0 DynamoVisualProgramming.DynamoSamples nuget. Once this PR merged today, it should be available soon.

@QilongTang QilongTang merged commit 9cf6acf into DynamoDS:master Jan 7, 2021
@ZiyunShang
Copy link
Contributor Author

@QilongTang OK, If the new package will not affect the function of D4R 2.10.0, I think it is acceptable. Thanks a lot!

@QilongTang
Copy link
Contributor

@ZiyunShang Thanks, I will ping you when it is ready

@ZiyunShang ZiyunShang deleted the UpgradeDynamoSampleFile branch January 7, 2021 02:49
@QilongTang
Copy link
Contributor

@ZiyunShang The new nugets are ready
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants