Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not aggregate node execution analytics anymore #11355

Closed
wants to merge 1 commit into from
Closed

Do not aggregate node execution analytics anymore #11355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/DynamoCore/Models/DynamoModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,18 +1044,18 @@ private void OnAsyncTaskStateChanged(DynamoScheduler sender, TaskStateChangedEve

if (Logging.Analytics.ReportingAnalytics)
{
var modifiedNodes = "";
if (updateTask.ModifiedNodes != null && updateTask.ModifiedNodes.Any())
{
modifiedNodes = updateTask.ModifiedNodes
.Select(n => n.GetOriginalName())
.Aggregate((x, y) => string.Format("{0}, {1}", x, y));
// Send analytics for each of modified nodes so they are counted individually
foreach (var node in updateTask.ModifiedNodes)
{
// Notice the executionTimeSpan is still for the whole delta computation
Dynamo.Logging.Analytics.TrackTimedEvent(
Categories.Performance,
e.Task.GetType().Name,
executionTimeSpan, node.GetOriginalName());
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like a good indicator of performance. How about only tracking when there is only 1 node being modified instead? That way we get less events but at least the info we get is closer to reality.

}

Dynamo.Logging.Analytics.TrackTimedEvent(
Categories.Performance,
e.Task.GetType().Name,
executionTimeSpan, modifiedNodes);
}

Debug.WriteLine(String.Format(Resources.EvaluationCompleted, executionTimeSpan));
Expand Down