-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Node Auto Complete in CustomNodeWorkspace #11307
Enable Node Auto Complete in CustomNodeWorkspace #11307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one comment
Are you planning to add any tests? |
Yes, working on it |
@zeusongit @reddyashish Unit test added. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* Re bind RequestNodeAutoCompleteSearch when open dyf * Add unit test
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Enable Node Auto Complete in CustomNodeWorkspace ( https://jira.autodesk.com/browse/DYN-3252).
Before this change, when opening a dyf,
RequestNodeAutoCompleteSearch
is unbind and never rebind. Switching from different dyns will always call workspace.loaded to rebind so the bug is buried only for dyf opening.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of