Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Node Auto Complete in CustomNodeWorkspace #11307

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 2, 2020

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Enable Node Auto Complete in CustomNodeWorkspace ( https://jira.autodesk.com/browse/DYN-3252).

Before this change, when opening a dyf, RequestNodeAutoCompleteSearch is unbind and never rebind. Switching from different dyns will always call workspace.loaded to rebind so the bug is buried only for dyf opening.
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link
Contributor

@zeusongit zeusongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

@zeusongit
Copy link
Contributor

Are you planning to add any tests?

@QilongTang
Copy link
Contributor Author

Are you planning to add any tests?

Yes, working on it

@QilongTang
Copy link
Contributor Author

@zeusongit @reddyashish Unit test added. PTAL

@QilongTang QilongTang added this to the 2.10.0 milestone Dec 2, 2020
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@QilongTang QilongTang merged commit b3b5c09 into master Dec 2, 2020
@QilongTang QilongTang deleted the EnableNodeAutoCompleteInCustomNodeWorkspace branch December 2, 2020 22:02
QilongTang added a commit that referenced this pull request Dec 2, 2020
* Re bind RequestNodeAutoCompleteSearch when open dyf

* Add unit test
@QilongTang QilongTang mentioned this pull request Dec 2, 2020
8 tasks
QilongTang added a commit that referenced this pull request Dec 3, 2020
* Re bind RequestNodeAutoCompleteSearch when open dyf

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants