Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Node Suggestions #11196

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Default Node Suggestions #11196

merged 5 commits into from
Oct 23, 2020

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Oct 22, 2020 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Add Default Node suggestions for case where suggestion algorithm returns no results. @zeusongit I think changes here will be related to your task as well.
image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@DynamoDS/dynamo

FYIs

@mjkkirschner @aparajit-pratap

@QilongTang QilongTang requested a review from zeusongit October 22, 2020 15:14
@QilongTang QilongTang added this to the 2.9.0 milestone Oct 22, 2020
zeusongit
zeusongit reviewed Oct 22, 2020
View reviewed changes
src/DynamoCoreWpf/ViewModels/Search/NodeAutoCompleteSearchViewModel.cs
@@ -57,7 +73,7 @@ internal void PopulateAutoCompleteCandidates()
/// The search elements can be made to appear in the node autocomplete search dialog.
/// </summary>
/// <returns>collection of node search elements</returns>
internal IEnumerable<NodeSearchElement> GetMatchingNodes()
internal IEnumerable<NodeSearchElement> GetMatchingSearchElements()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this change?

Copy link
Contributor Author

@QilongTang QilongTang Oct 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed since the function itself does not really return nodes (usually referring to node models or node view models) but rather than search elements, just to reduce confusion in the future

zeusongit
zeusongit approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@zeusongit zeusongit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

@QilongTang
Copy link
Contributor Author

@aparajit-pratap @zeusongit Addressed the comments

@QilongTang QilongTang merged commit 88eeb47 into master Oct 23, 2020
@QilongTang QilongTang deleted the DefaultStateForNodeAutoComplete branch October 23, 2020 14:56
QilongTang added a commit that referenced this pull request Oct 23, 2020
@QilongTang
Default Node Suggestions (#11196)
9b8f7f6 
* Default Node Suggestions

* Make member internal

* CleanUp

* Comments

* Comments
@QilongTang QilongTang mentioned this pull request Oct 23, 2020
Merged
8 tasks
QilongTang added a commit that referenced this pull request Oct 23, 2020
@QilongTang
Default Node Suggestions (#11196) (#11200)
bddb435 
* Default Node Suggestions

* Make member internal

* CleanUp

* Comments

* Comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amoursol Amoursol Amoursol left review comments

@aparajit-pratap aparajit-pratap aparajit-pratap left review comments

@zeusongit zeusongit zeusongit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QilongTang @aparajit-pratap @Amoursol @zeusongit