Place suggested node wrt node height and width #11173
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This builds on top of PR #11164
The new node chosen from node autocomplete needs to be placed relative to the initial node relative to its location as well as the sizes of the initial node and new node. However, the size of the new node is not available until the node's view is created. For this reason, we have tried to split the creation of the node and its placement and connection into two separate commands. The placement and connection command (
PlaceAndConnectNodeCommand
) is executed only once the node view is ready.This solution takes care of the issue of placing different sized nodes relative to the initial node but placing them vertically relative to other input nodes is still a challenge as we would need to know the size of all input nodes so that we can arrange them in a manner such that they don't overlap with each other.
Having tried this approach, I would like to try out the auto-layout solution again but laying out only the input nodes.
Declarations
Check these if you believe they are true
*.resx
files