Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place suggested node wrt node height and width #11173

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Oct 12, 2020

Purpose

This builds on top of PR #11164

The new node chosen from node autocomplete needs to be placed relative to the initial node relative to its location as well as the sizes of the initial node and new node. However, the size of the new node is not available until the node's view is created. For this reason, we have tried to split the creation of the node and its placement and connection into two separate commands. The placement and connection command (PlaceAndConnectNodeCommand) is executed only once the node view is ready.
place_and_connect_nodes

This solution takes care of the issue of placing different sized nodes relative to the initial node but placing them vertically relative to other input nodes is still a challenge as we would need to know the size of all input nodes so that we can arrange them in a manner such that they don't overlap with each other.

Having tried this approach, I would like to try out the auto-layout solution again but laying out only the input nodes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant