Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Solid.ByRuledLoft #11165

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Oct 6, 2020

Purpose

Adds icons created by Jingyi for the new node Solid.ByRuledLoft.

Here is a screenshot of how they look like in Dynamo:

Screen Shot 2020-10-06 at 8 47 34 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @aparajit-pratap

Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmisol I think you also need to check in the icon png files.

@mmisol
Copy link
Collaborator Author

mmisol commented Oct 6, 2020

@aparajit-pratap They are embedded into the resx file

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Oct 6, 2020

@aparajit-pratap
Copy link
Contributor

@mmisol I think I know why the node description has not been updated. The code comments in IGeometryFactory.cs need to also be copied to ProtoGeometry. We have to do this manually for now as the T4 template auto-generation is broken currently. Hoewever, we can make that change later. If you could just add the png's, we can merge this PR.

@mmisol mmisol merged commit f7cc320 into DynamoDS:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants