Fix path to custom fixers for python migration #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
changed the title
mmisol
approved these changes
Sep 29, 2020
| @@ -64,6 +64,7 @@ Dynamo.sln.DotSettings | |||
| *.sdf | |||
| *.backup | |||
| *.dgml | |||
There was a problem hiding this comment.
Just curious, what is this exception here for?
There was a problem hiding this comment.
I was experimenting with the new IntelliTrace feature in VS 2019. This file is generated using that tool, I thought it would be good to exclude it as it's generated by VS.
| using (PyScope scope = Py.CreateScope()) | ||
| { | ||
| scope.Set(INPUT_NAME, code.ToPython()); | ||
| scope.Exec(Get2To3MigrationScript()); | ||
|
|
||
| var path = Path.GetDirectoryName(asm.Location); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes issue with python migration assistant not working for host environments.
See slack thread: https://autodesk.slack.com/archives/C0W60575Z/p1600674768017200
Manually tested in Revit.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@DynamoDS/dynamo
FYIs
@Amoursol
@QilongTang