Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse function typed params with namespace #11138

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Sep 22, 2020

Purpose

Fixes a parser incompatibility with typed parameters in a function
signature when these contained a namespace declaration. Tests are added
for this and related cases.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@aparajit-pratap @QilongTang

FYIs

@DynamoDS/dynamo

Fixes a parser incompatibility with typed parameters in a function
signature when these contained a namespace declaration. Tests are added
for this and related cases.
Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for fixing this!

@mmisol mmisol merged commit 923a4fe into DynamoDS:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants